On Tue, Apr 11, 2023 at 2:53 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > On Tue, Apr 11, 2023 at 2:31 AM Stephen Frost <sfr...@snowman.net> wrote: > > Have you tried running the tests in src/test/kerberos with elver? Or is > > it configured to run them? Would be awesome if it could be, or if > > there's issues with running the tests on FBSD w/ MIT Kerberos, I'd be > > happy to try and help work through them.
Oh, the FreeBSD CI already runs the kerberos test and it uses the krb5 package, because the image it uses installs that[1] and at least the Meson build automatically prefers that over Heimdal. So the CI in the postgres/postgres account tested it[2] as soon as you committed, and cfbot was testing all along in the commitfest. It's not skipped and that test would clearly BAIL_OUT if it detected Heimdal. Is that good enough? I have OpenBSD and NetBSD vagrant images around, do you want me to test those too? As for elver, I remembered an unfortunate detail: it doesn't currently have kerberos enabled in PG_TEXT_EXTRA, because it the test depends on localhost being 127.0.0.1 which isn't quite true on this box (container tech with an unusual network stack, long boring story) and I hadn't got around to figuring out what to do about that. I can look into it if you want, or perhaps you are satisfied with CI proving that FreeBSD likes your patch. [1] https://github.com/anarazel/pg-vm-images/blob/main/packer/freebsd.pkr.hcl [2] https://cirrus-ci.com/task/6378179762323456?logs=test_world#L43
