On Thu, Apr 6, 2023 at 12:10 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Apr 5, 2023 at 9:27 PM Drouvot, Bertrand > <bertranddrouvot...@gmail.com> wrote: > > > > Another comment on 0001. > extern void CheckSlotRequirements(void); > extern void CheckSlotPermissions(void); > +extern void ResolveRecoveryConflictWithLogicalSlots(Oid dboid, > TransactionId xid, char *reason); > > This doesn't seem to be called from anywhere. >
Few other comments: ================== 0004 1. + * - physical walsenders in case of new time line and cascade + * replication is allowed. + * - logical walsenders in case of new time line or recovery is in progress + * (logical decoding on standby). + */ + WalSndWakeup(switchedTLI && AllowCascadeReplication(), + switchedTLI || RecoveryInProgress()); Do we need AllowCascadeReplication() check specifically for physical walsenders? I think this should be true for both physical and logical walsenders. 0005 2. --- a/src/backend/access/transam/xlogfuncs.c +++ b/src/backend/access/transam/xlogfuncs.c @@ -38,6 +38,7 @@ #include "utils/pg_lsn.h" #include "utils/timestamp.h" #include "utils/tuplestore.h" +#include "storage/standby.h" The header includes should be in alphabetical order. -- With Regards, Amit Kapila.
