On Thu, Feb 02, 2023 at 11:34:37AM +0000, Dean Rasheed wrote: > I didn't reply until now, but I'm solidly in the camp of committers > who care about keeping the tree properly indented, and I wouldn't have > any problem with such a check being imposed.
So do I. pgindent is part of my routine when it comes to all the patches I merge on HEAD, and having to clean up unrelated diffs in the files touched after an indentation is always annoying. FWIW, I just use a script that does pgindent, pgperltidy, pgperlcritic and `make reformat-dat-files` in src/include/catalog. > I regularly run pgindent locally, and if I ever commit without > indenting, it's either intentional, or because I forgot, so the > reminder would be useful. > > And as someone who runs pgindent regularly, I think this will be a net > time saver, since I won't have to skip over other unrelated indent > changes all the time. +1. -- Michael
signature.asc
Description: PGP signature
