On Tue, Jan 24, 2023 at 02:55:07AM +0000, houzj.f...@fujitsu.com wrote: > I noticed one minor thing in this commit. > > - > LogicalRepCtx->last_start_dsh = DSM_HANDLE_INVALID; > - > > The code takes the last_start_dsh as dsm_handle, but it seems it is a > dsa_pointer. > " typedef dsa_pointer dshash_table_handle;" This won’t cause any problem, but > I feel > It would be easier to understand if we take it as dsa_pointer and use > InvalidDsaPointer here, > like what he attached patch does. What do you think ?
IMO ideally there should be a DSA_HANDLE_INVALID and DSHASH_HANDLE_INVALID for use with dsa_handle and dshash_table_handle, respectively. But your patch does seem like an improvement. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
