On Thu, Jan 5, 2023 at 10:49 PM Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Thu, Jan 05, 2023 at 11:34:37AM +0530, Amit Kapila wrote: > > On Thu, Jan 5, 2023 at 10:16 AM Nathan Bossart <nathandboss...@gmail.com> > > wrote: > >> In v12, I moved the restart for two_phase mode to the end of > >> process_syncing_tables_for_apply() so that we don't need to rely on another > >> iteration of the loop. > > > > This should work but it is better to add a comment before calling > > CommandCounterIncrement() to indicate that this is for making changes > > to the relation state visible. > > Will do. >
Isn't it better to move this part into a separate patch as this is useful even without the main patch to improve wakeups? > > Thinking along similar lines, won't apply worker need to be notified > > of SUBREL_STATE_SYNCWAIT state change by the tablesync worker? > > wait_for_worker_state_change() should notify the apply worker in this case. > I think this is yet to be included in the patch, right? -- With Regards, Amit Kapila.
