Thanks for looking at this. Em ter., 20 de dez. de 2022 às 21:51, Justin Pryzby <pry...@telsasoft.com> escreveu:
> On Fri, Nov 25, 2022 at 06:27:04PM -0300, Ranier Vilela wrote: > > 5. Use boolean operator with boolean operands > > (b/src/backend/commands/tablecmds.c) > > tablecmds.c: right. Since 074c5cfbf > > pg_dump.c: right. Since b08dee24a > > > 4. Fix dead code (src/backend/utils/adt/formatting.c) > > Np->sign == '+', is different than "!= '-'" and is different than "!= > '+'" > > So the else is never hit. > > formatting.c: I don't see the problem. > > if (Np->sign != '-') > ... > else if (Np->sign != '+' && IS_PLUS(Np->Num)) > ... > > You said that the "else" is never hit, but why ? > Maybe this part of the patch is wrong. The only case for the first if not handled is sign == '-', sign == '-' is handled by else. So always the "else is true", because sign == '+' is handled by the first if. regards, Ranier Vilela
