> On 15 Dec 2022, at 01:56, Kyotaro Horiguchi <horikyota....@gmail.com> wrote: > > At Wed, 14 Dec 2022 10:40:45 +0100, Daniel Gustafsson <dan...@yesql.se> wrote > in >>> On 14 Dec 2022, at 08:04, Peter Eisentraut >>> <peter.eisentr...@enterprisedb.com> wrote: >>> >>> On 07.12.22 17:33, Peter Eisentraut wrote: >>>> I think if we want to make this configurable on the fly, and environment >>>> variable would be much easier, like >>>> my $mode = $ENV{PG_TEST_PG_UPGRADE_MODE} || '--copy'; >>> >>> Here is an updated patch set that incorporates this idea. > > We have already PG_TEST_EXTRA. Shouldn't we use it here as well?
I think those are two different things. PG_TEST_EXTRA adds test suites that aren't run by default, this proposal is to be able to inject options into a test suite to modify its behavior. -- Daniel Gustafsson https://vmware.com/