Em qui., 6 de out. de 2022 às 21:21, Tom Lane <t...@sss.pgh.pa.us> escreveu:
> Ranier Vilela <ranier...@gmail.com> writes: > > My main concerns is this point: > > /* If already matched on earlier page, do no extra work */ > > - if (key->entryRes[j]) > > + if (key->entryRes[j] == GIN_TRUE) > > continue; > > > If GIN_MAYBE cases are erroneously ignored. > > So, if that's a bug, you should be able to produce a test case? > No Tom, unfortunately I don't have the knowledge to create a test with GIN_MAYBE values. With the patch, all current tests pass. Either there are no bugs, or there are no tests that detect this specific case. And I agree with you, without a test showing the bug, there's not much chance of the patch progressing. Unless someone with more knowledge can say that the patch improves robustness. regards, Ranie Vilela
