On Tue, Sep 27, 2022 at 6:14 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > No. Since cluster_name is PGC_POSTMATER, we leak a little postmaster > memory only once when starting up. application_name is PGC_USERSET but > since we normally allocate memory in PortalMemoryContext we eventually > can free it.
Oh, I see; thank you for the correction. And even if someone put an application_name into their postgresql.conf, and then changed it a bunch of times, we'd free the leaked memory from the config_cxt that's created in ProcessConfigFile(). Is there a reason we don't provide a similar temporary context during InitializeGUCOptions()? Naively it seems like that would suppress any future one-time leaks, and maybe cut down on some Valgrind noise. Then again, maybe there's just not that much demand for pallocs during GUC hooks. Thanks, --Jacob
