Hi, > > 01. filename > > The word-ordering of filename seems not good > > because you defined the new worker as "parallel apply worker". > > > > I think in the future we may have more files for apply work (like > applyddl.c for DDL apply work), so it seems okay to name all apply > related files in a similar way.
> > That flag is set only when an apply worker spill the transaction to the > > disk. > > How about "in_streamed_transaction" -> "in_spilled_transaction"? > > > > Isn't this an existing variable? If so, it doesn't seem like a good > idea to change the name unless we are changing its meaning. Both of you said are reasonable. They do not have to be modified. Best Regards, Hayato Kuroda FUJITSU LIMITED
