> On 9 Sep 2022, at 11:00, Andrew Dunstan <and...@dunslane.net> wrote:
> 
>> On Sep 9, 2022, at 5:53 PM, John Naylor <john.nay...@enterprisedb.com> wrote:
>> 
>> Note that the grammar has shift-reduce conflicts. 

> Looks like the last rule for Filters should not be there.

Correct, fixed in the attached.

> I do wonder whether we should be using bison/flex here, seems like using a
> sledgehammer to crack a nut.


I don't the capabilities of the tool is all that interesting compared to the
long term maintainability and readability of the source code.  Personally I
think a simple Bison/Flex parser is easier to read and reason about than the
corresponding written in C.

--
Daniel Gustafsson               https://vmware.com/

Attachment: v4-0001-Add-include-exclude-filtering-via-file-in-pg_dump.patch
Description: Binary data

Reply via email to