On Fri, Sep 2, 2022 at 6:21 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are my review comments for the latest patch v44-0001. > ... > > 6. src/backend/commands/subscriptioncmds.c > > + if (bsearch(&relid, subrel_local_oids, > + subrel_count, sizeof(Oid), oid_cmp)) > + isnewtable = false; > > SUGGESTION (search PG source - there are examples like this) > newtable = bsearch(&relid, subrel_local_oids, subrel_count, > sizeof(Oid), oid_cmp); >
Oops. Of course, I meant !bsearch SUGGESTION newtable = !bsearch(&relid, subrel_local_oids, subrel_count, sizeof(Oid), oid_cmp); ------ Kind Regards, Peter Smith. Fujitsu Australia
