On Wed, 31 Aug 2022 at 11:45, Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for patch v43-0002: > > ====== > > 1. doc/src/sgml/ref/create_subscription.sgml > > @@ -403,7 +403,9 @@ CREATE SUBSCRIPTION <replaceable > class="parameter">subscription_name</replaceabl > warning to notify the user to check the publisher tables. Before > continuing > with other operations the user should check that publisher tables did not > have data with different origins to prevent data inconsistency issues on > the > - subscriber. > + subscriber. Refer to <xref linkend="replication-between-primaries"/> for > + how <literal>copy_data</literal> and <literal>origin</literal> can be used > + to set up replication between primaries. > </para> > > Regarding my earlier v43-0001 review (see [1] comment #2) perhaps > another pg docs section should be added in the > logical-replication.sgml (e.g. "Specifying origins during CREATE > SUBSCRIPTION"), so then this Notes text also should have more added to > it. > > SUGGESTION > Refer to <XXX_REF> for details about potential initialization > inconsistency warnings using origin=NONE. > Refer to <YYY_REF> for how copy_data and origin can be used to set up > replication between primaries.
I have moved all these contents to a separate section in the logical-replication page. I have referred to this link from the documentation of origin and copy_data parameter. I have also referred to "setting up replication between primaries" in the newly added section. Since this new section is referred to from other places, I felt we need not provide a link from create_subscription notes. The changes for the same are available at [1]. [1] - https://www.postgresql.org/message-id/CALDaNm0NRJ1O1cYcZD%3Df7NgynozFprb7zpJSayFN5rcaS44G6Q%40mail.gmail.com Regards, Vignesh
