On Thu, Aug 25, 2022 at 08:29:43PM -0700, Andres Freund wrote: > It's really not great that 7f3e17b4827 disabled randomization without even a > comment as to why...
This story is on this thread, with some processes not able to start: https://www.postgresql.org/message-id/BD0D89EC2438455C9DE0DC94D36912F4@maumau > There actually seems to have been a lot of work in that area. See 617dc6d299c > / bcbf2346d69 and as well as the retrying in 45e004fb4e39. Those weren't > prevented by us disabling ASLR. Indeed. 45e004f looks like the most interesting bit here. FWIW, I would not mind re-enabling that on HEAD, as of something like the attached. I have done a dozen of runs without seeing a test failure, and knowing that we don't support anything older than Win10 makes me feel safer about this change. Any objections? -- Michael
From 0fde47c2d4e65bd9f1f5a7b4607f8b8b95162242 Mon Sep 17 00:00:00 2001
From: Michael Paquier <mich...@paquier.xyz>
Date: Sat, 27 Aug 2022 10:20:53 +0900
Subject: [PATCH] Re-enable ASLR on Windows
---
src/tools/msvc/MSBuildProject.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/tools/msvc/MSBuildProject.pm b/src/tools/msvc/MSBuildProject.pm
index 62acdda3a1..594729ceb7 100644
--- a/src/tools/msvc/MSBuildProject.pm
+++ b/src/tools/msvc/MSBuildProject.pm
@@ -347,7 +347,6 @@ sub WriteItemDefinitionGroup
<ProgramDatabaseFile>.\\$cfgname\\$self->{name}\\$self->{name}.pdb</ProgramDatabaseFile>
<GenerateMapFile>false</GenerateMapFile>
<MapFileName>.\\$cfgname\\$self->{name}\\$self->{name}.map</MapFileName>
- <RandomizedBaseAddress>false</RandomizedBaseAddress>
<!-- Permit links to MinGW-built, 32-bit DLLs (default before VS2012). -->
<ImageHasSafeExceptionHandlers/>
<SubSystem>Console</SubSystem>
--
2.37.2
signature.asc
Description: PGP signature
