At Tue, 16 Aug 2022 16:04:23 -0700, Nathan Bossart <nathandboss...@gmail.com> wrote in > On Mon, Aug 15, 2022 at 02:47:25PM -0700, Jeremy Schneider wrote: > > I'll take a look at the patch if I can... and I'm hopeful that we're > > able to move this idea forward and get this little gap in PG filled once > > and for all! > > Thanks! > > I noticed that the "result" variable in pg_stat_get_backend_idset() is kind > of pointless after my patch is applied, so here is a v2 with it removed.
It seems to be a sensible way to expose the PGPROC backend ids to SQL interface. It inserts bsearch into relatively frequently-called function but (I believe) that doesn't seem to matter much (comparing to, for example, the size of id->position translation table). I don't think pgstat_fetch_stat_beentry needs to check for out-of-range ids anymore. That case is a kind of rare and bsearch properly handles it. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
