On Fri, Aug 19, 2022 at 1:37 PM mahendrakar s <mahendrakarfo...@gmail.com> wrote: > > Hi Bharath, > I reviewed your patch. Minor comments.
Thanks.
> 1. Why are we not using durable_unlink instead of unlink to remove the
> partial tmp files?
durable_unlink() issues fsync on the parent directory, if used, those
fsync() calls will be per partial.tmp file. Moreover, durable_unlink()
is backend-only, not available for tools i.e. FRONTEND code. If we
don't durably remove the pratial.tmp file, it will get deleted in the
next cycle anyways, so no problem there.
> 2. Below could be a simple if(shouldcreatetempfile){} else{} as in error case
> we need to return NULL.
Yeah, that way it is much simpler.
Please review the attached v6 patch.
--
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/
v6-0001-Make-WAL-file-initialization-by-pg_receivewal-ato.patch
Description: Binary data
