On Thu, Sep 22, 2022 at 10:07 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Thu, Sep 22, 2022 at 07:16:41AM +0530, Bharath Rupireddy wrote: > > t/010_pg_basebackup.pl ... 134/? > > # Failed test 'pg_basebackup reports checksum mismatch stderr > > /(?^s:^WARNING.*checksum verification failed)/' > > # at t/010_pg_basebackup.pl line 769. > > # 'unrecognized win32 error code: 123WARNING: > > checksum verification failed in file "./base/5/16399", block 0: > > calculated 4C09 but expected B3F6 > > # pg_basebackup: error: checksum error occurred > > Shouldn't we extend the mapping table in win32error.c so as the > information provided is more useful when seeing this error, then? > There could be other code path able to trigger this failure, or other > hackers working on separate features that could benefit from this > extra information.
Thanks. I will start a separate thread to discuss that. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com