On Wed, Aug 3, 2022 at 1:20 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Wed, Aug 3, 2022 at 3:52 PM shiy.f...@fujitsu.com > <shiy.f...@fujitsu.com> wrote: > > > > On Wed, Aug 3, 2022 12:06 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > > > > > I've attached updated patches that incorporated the above comments as > > > well as the comments from Shi yu. Please review them. > > > > > > > Thanks for updating the patch. > > > > I noticed that in SnapBuildXidSetCatalogChanges(), "i" is initialized in > > the if > > branch in REL10 patch, which is different from REL11 patch. Maybe we can > > modify > > REL11 patch to be consistent with REL10 patch. > > > > The rest of the patch looks good to me. > > Oops, thanks for pointing it out. I've fixed it and attached updated > patches for all branches so as not to confuse the patch version. There > is no update from v12 patch on REL12 - master patches. >
Thanks for the updated patches, the changes look good to me. Horiguchi-San, and others, do you have any further comments on this or do you want to spend time in review of it? If not, I would like to push this after the current minor version release. -- With Regards, Amit Kapila.
