At Wed, 3 Aug 2022 08:51:40 +0530, Amit Kapila <amit.kapil...@gmail.com> wrote in > On Wed, Aug 3, 2022 at 7:05 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > Looking at other codes in snapbuild.c, we call CloseTransientFile() > > before erroring out in SnapBuildSerialize(). I think it's better to > > keep it consistent with nearby codes in this patch. I think if we > > prefer the style of closing the file by ereport(ERROR), it should be > > done for all of them in a separate patch. > > > > +1. I also feel it is better to change it in a separate patch as this > is not a pattern introduced by this patch.
Agreed. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
