On Thu, Jul 7, 2022 at 1:43 PM Alexander Korotkov <aekorot...@gmail.com> wrote: > On Thu, Jul 7, 2022 at 2:16 AM Steve Chavez <st...@supabase.io> wrote: > > Thanks Alexander! > > > > wrt to the new patch. I think the following comment is misleading since > > keyDeleted can be true or false: > > > > + /* switch equal_match to false so we only find greater matches now */ > > + node = (IntRBTreeNode *) rbt_find_great(tree, (RBTNode *) &searchNode, > > + keyDeleted); > > > > Maybe it should be the same used for searching lesser keys: > > > > + /* > > + * Find the next key. If the current key is deleted, we can pass > > + * equal_match == true and still find the next one. > > + */ > > Thank you for catching this. > The revised version of patch is attached!
Pushed! ------ Regards, Alexander Korotkov
