On Wed, Jun 22, 2022 at 8:05 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Jun 22, 2022 at 10:09 AM Amit Langote <amitlangot...@gmail.com> wrote: > > On Wed, Jun 22, 2022 at 12:02 PM houzj.f...@fujitsu.com > > <houzj.f...@fujitsu.com> wrote: > > > Since the patch has been committed. Attach the last patch to fix the > > > memory leak. > > > > > > The bug exists on PG10 ~ PG15(HEAD). > > > > > > For HEAD,PG14,PG13, to fix the memory leak, I think we should use > > > free_attrmap instead of pfree and release the no-longer-useful attrmap > > > When rebuilding the map info. > > > > > > For PG12,PG11,PG10, we only need to add the code to release the > > > no-longer-useful attrmap when rebuilding the map info. We can still use > > > pfree() because the attrmap in back-branch is a single array like: > > > > > > entry->attrmap = palloc(desc->natts * sizeof(AttrNumber)); > > > > LGTM, thank you. > > LGTM as well. One thing I am not completely sure about is whether to > make this change in PG10 for which the final release is in Nov? > AFAICS, the leak can only occur after the relcache invalidation on the > subscriber which may or may not be a very frequent case. What do you > guys think?
Agree that the leak does not seem very significant, though... > Personally, I feel it is good to fix it in all branches including PG10. ...yes, why not. -- Thanks, Amit Langote EDB: http://www.enterprisedb.com
