On Tue, Jun 21, 2022 at 8:02 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Jun 21, 2022 at 7:49 AM Amit Langote <amitlangot...@gmail.com> wrote: > > > > > > I think it should spell out REPLICA IDENTITY explicitly to avoid the > > commit being confused to have to do with "Referential Integrity > > checking". > > > > This makes sense. I'll take care of this. >
After pushing this patch, buildfarm member prion has failed. https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=prion&br=HEAD It seems to me that the problem could be due to the reason that the entry returned by logicalrep_partition_open() may not have the correct value for localrel when we found the entry and localrelvalid is also true. The point is that before this commit we never use localrel value from the rel entry returned by logicalrep_partition_open. I think we need to always update the localrel value in logicalrep_partition_open(). -- With Regards, Amit Kapila.
