On Mon, Jun 20, 2022 at 3:16 PM vignesh C <vignes...@gmail.com> wrote: > > On Mon, Jun 20, 2022 at 2:37 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Thu, Jun 16, 2022 at 3:48 PM vignesh C <vignes...@gmail.com> wrote: > > > > > > On Wed, Jun 15, 2022 at 12:09 PM Peter Smith <smithpb2...@gmail.com> > > > wrote: > > > > > > > > > Thanks for the comments, the attached v21 patch has the changes for the > > > same. > > > > I have done some basic review of v21 and I have a few comments, > > > > 1. > > +/* > > + * The subscription will request the publisher to only send changes that > > + * originated locally. > > + */ > > +#define LOGICALREP_ORIGIN_LOCAL "local" > > + > > +/* > > + * The subscription will request the publisher to send any changes > > regardless > > + * of their origin > > + */ > > +#define LOGICALREP_ORIGIN_ANY "any" > > > > Are we planning to extend this to more options or are we planning to > > support the actual origin name here? If not then why isn't it just > > bool? I think the comments and the patch commit message should > > explain the details behind it if it has been already discussed and > > concluded. > > Currently we only support local and any. But this was designed to > accept string instead of boolean type, so that it can be extended > later to support filtering of origin names specified by the user in > the later versions. The same was also discussed in pg unconference as > mentioned in [1]. I will add it to the commit message and a comment > for the same in the next version.
Thanks for the comment, the v22 patch attached at [1] has the changes for the same. [1] - https://www.postgresql.org/message-id/CALDaNm1h-9UNi_Jo_K%2BPK34tXBmV7fhj5C_nB8YzGA9rmUwHEA%40mail.gmail.com Regards, Vignesh
