On Mon, Mar 28, 2022 at 12:52 PM Dagfinn Ilmari Mannsåker <ilm...@ilmari.org> wrote: > > True, but that also means it shows up in the actual failure message, > > which seems too verbose. By just using 'print', it ends up in the log > > file if it's needed, but not anywhere else. Maybe there's a better way > > to do this, but I don't think using note() is what I want. > > That is the difference between note() and diag(): note() prints to > stdout so is not visible under a non-verbose prove run, while diag() > prints to stderr so it's always visible.
OK, but print doesn't do either of those things. The output only shows up in the log file, even with --verbose. Here's an example of what the log file looks like: # Running: pg_verifybackup -n -m /Users/rhaas/pgsql/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/backup_manifest -e /Users/rhaas/pgsql/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/extracted-backup backup successfully verified ok 6 - verify backup, compression gzip As you can see, there is a line here that does not begin with #. That line is the standard output of a command that was run by the test script. -- Robert Haas EDB: http://www.enterprisedb.com
