On Tue, Feb 15, 2022 at 11:26 AM Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Feb 9, 2022 at 8:41 AM Abhijit Menon-Sen <a...@toroid.org> wrote: > > It took me a while to assimilate these patches, including the backup > > targets one, which I hadn't looked at before. Now that I've wrapped my > > head around how to put the pieces together, I really like the idea. As > > you say, writing non-trivial integrations in C will take some effort, > > but it seems worthwhile. It's also nice that one can continue to use > > pg_basebackup to trigger the backups and see progress information. > > Cool. Thanks for having a look. > > > Yes, it looks simple to follow the example set by basebackup_to_shell to > > write a custom target. The complexity will be in whatever we need to do > > to store/forward the backup data, rather than in obtaining the data in > > the first place, which is exactly as it should be. > > Yeah, that's what made me really happy with how this came out. > > Here's v2, rebased and with documentation added.
I don't hear many comments on this, but I'm pretty sure that it's a good idea, and there haven't been many objections to this patch series as a whole, so I'd like to proceed with it. If nobody objects vigorously, I'll commit this next week. Thanks, -- Robert Haas EDB: http://www.enterprisedb.com
