On Thu, Mar 24, 2022 at 9:29 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Thu, Mar 24, 2022 at 1:29 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > In the latest version I have fixed this issue by using a non > > conflicting name, because when it was compiled with-icu the foobar5 > > was already used and we were seeing failure. Apart from this I have > > fixed the duplicate cleanup problem by passing an extra parameter to > > RelationCreateStorage, which decides whether to register for on-abort > > delete or not and added the comments for the same. IMHO this looks > > the most cleaner way to do it, please check the patch and let me know > > your thoughts. > > I think that might be an OK way to do it. I think if we were starting > from scratch we'd probably want to come up with some better system, > but that's true of a lot of things.
Right. > I went over your version and changed some comments. I also added > documentation for the new wait event. Here's a new version. > Thanks, I have gone through your changes in comments and docs and those LGTM. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
