On Wed, Mar 23, 2022 at 9:13 PM Andres Freund <and...@anarazel.de> wrote: > > Hi, > > On 2022-03-23 18:49:11 +0530, Dilip Kumar wrote: > > I think directly using smgrcreate() is a better idea instead of first > > registering and then unregistering it. I have made that change in > > the attached patch. After this change now we can merge creating the > > MAIN_FORKNUM also in the loop below where we are creating other > > fork[1] with one extra condition but I think current code is in more > > sync with the other code where we are doing the similar things so I > > have not merged it in the loop. Please let me know if you think > > otherwise. > > FWIW, this fails tests: https://cirrus-ci.com/build/4929662173315072 > https://cirrus-ci.com/task/6651773434724352?logs=test_bin#L121 > https://cirrus-ci.com/task/6088823481303040?logs=test_world#L2377
Strange to see that these changes are making a failure in the file_copy strategy[1] because we made changes only related to the wal_log strategy. However I will look into this. Thanks. [1] Failed test 'createdb -T foobar2 foobar5 -S file_copy exit code 0' -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
