Hi, On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > On 3/22/22 22:23, Andres Freund wrote: > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: > >> I was about to propose adding headerscheck / cpluspluscheck to the CI file > >> so > >> that cfbot can catch future issues. > > The attached patch does so, with ICU disabled to avoid the problems > > discussed > > in the thread. Example run: > > https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0 > > > > Unless somebody sees a reason not to, I'm planning to commit this soon. > > > > That only helps when running the CI/cfbot setup. Fixing it for other > (manual or buildfarm) users would be nice. Luckily crake isn't building > with ICU.
Oh, I agree we need to fix it properly. I just don't yet know how to - see the list of alternatives upthread. Seems no reason to hold up preventing further problems via CI / cfbot though. Greetings, Andres Freund
