On 3/22/22 22:23, Andres Freund wrote: > Hi, > > On 2022-03-22 17:20:24 -0700, Andres Freund wrote: >> I was about to propose adding headerscheck / cpluspluscheck to the CI file so >> that cfbot can catch future issues. > The attached patch does so, with ICU disabled to avoid the problems discussed > in the thread. Example run: > https://cirrus-ci.com/task/6326161696358400?logs=headers_headerscheck#L0 > > Unless somebody sees a reason not to, I'm planning to commit this soon. >
That only helps when running the CI/cfbot setup. Fixing it for other (manual or buildfarm) users would be nice. Luckily crake isn't building with ICU. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com