On Fri, Mar 4, 2022 at 11:45 AM osumi.takami...@fujitsu.com <osumi.takami...@fujitsu.com> wrote: > > On Friday, March 4, 2022 2:23 PM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > I've attached updated patches. > Hi, thank you for updating the patch. > > One comment on v4. > > In v4-0002, we introduce 'commit_lsn' in the ApplyErrorCallbackArg. > This member is set for prepare, rollback prepared and stream_abort as well. > The new log message format is useful when we have a prepare transaction > that keeps failing on the subscriber and want to know the target transaction > for the pg_replication_origin_advance(), right ? > If this is true, I wasn't sure if the name 'commit_lsn' is the > most accurate name for this variable. Should we adjust the name a bit ? >
If we want to change this variable name, the other options could be 'end_lsn', or 'finish_lsn'. -- With Regards, Amit Kapila.
