On Fri, Mar 4, 2022 at 10:53 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Fri, Mar 4, 2022 at 11:27 AM osumi.takami...@fujitsu.com > <osumi.takami...@fujitsu.com> wrote: > > > > (4) one confirmation > > > > We don't have a TAP test of pg_replication_origin_advance() > > for v3, that utilizes this new log in a logical replication setup. > > This is because existing tests for this function (in test_decoding) is only > > for permission check > > and argument validation, and we're just changing error message itself. > > Is this correct ? > > Yeah, I think it’s a good idea to add test in general but I don't > think we should include the tests for skipping a transaction by using > pg_replication_origin() in this patch because it's an existing way and > upcoming ALTER SUBSCRIPTION SKIP patch includes the tests and it's > more appropriate way. But if others also think it should do that too > along with this update, I'm happy to add tests. >
I also don't see a reason why this patch should add any tests related to origin. -- With Regards, Amit Kapila.
