On Sun, Feb 20, 2022 at 1:03 AM Yugo NAGATA <nag...@sraoss.co.jp> wrote: > I think we can use this macro also in hash_multirange, hash_range, > and JsonbHashScalarValue as in the attached patch. How about replacing > them with the macro, too.
Good find. I also found one more in hashfn.c. On Sat, Feb 19, 2022 at 11:28 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Some comments now look a bit too obvious to keep around, but maybe > > they should be replaced with a "why", instead of a "what": > > Yeah. Maybe like "combine successive hashkeys by rotating"? Done that way. Pushed, thank you both for looking! -- John Naylor EDB: http://www.enterprisedb.com