On Sat, Feb 19, 2022 at 8:21 PM Andres Freund <and...@anarazel.de> wrote: > Why does anything need to happen to it from vacuum's POV? It'll not be a > problem for freezing etc. Until it's deleted vacuum doesn't need to care. > > Probably worth a WARNING, and amcheck definitely needs to detect it, but > otherwise I think it's fine to just continue.
Maybe that's true, but it's just really weird to imagine not having an LP_REDIRECT that points to the LIVE item here, without throwing an error. Seems kind of iffy, to say the least. > >I guess it doesn't actually matter if we leave an aborted DEAD tuple > >behind, that we could have pruned away, but didn't. The important > >thing is to be consistent at the level of the page. > > That's not ok, because it opens up dangers of being interpreted differently > after wraparound etc. > > But I don't see any cases where it would happen with the new pruning logic in > your patch and sharing the HTSV status array? Right. Fundamentally, there isn't any reason why it should matter that VACUUM reached the heap page just before (rather than concurrent with or just after) some xact that inserted or updated on the page aborts. Just as long as we have a consistent idea about what's going on at the level of the whole page (or maybe the level of each HOT chain, but the whole page level seems simpler to me). -- Peter Geoghegan
