On 1/25/22 13:43, Alvaro Herrera wrote: > On 2022-Jan-24, Peter Eisentraut wrote: > >> +decinteger {decdigit}(_?{decdigit})* >> +hexinteger 0[xX](_?{hexdigit})+ >> +octinteger 0[oO](_?{octdigit})+ >> +bininteger 0[bB](_?{bindigit})+ > I think there should be test cases for literals that these seemingly > strange expressions reject, which are a number with trailing _ (0x123_), > and one with consecutive underscores __ (0x12__34). > > I like the idea of these literals. I would have found them useful on > many occassions.
+1. I can't remember the number of times I have miscounted a long string of digits in a literal. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com