On Mon, Nov 29, 2021 at 7:12 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Sat, Nov 27, 2021 at 7:56 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > Thank you for updating the patch! > > > I have made a number of changes in the attached patch which includes > > (a) the patch was trying to register multiple array entries for the > > same subscription which doesn't seem to be required, see changes in > > pgstat_vacuum_stat, (b) multiple changes in the test like reduced the > > wal_retrieve_retry_interval to 2s which has reduced the test time to > > half, remove the check related to resetting of stats as there is no > > guarantee that the message will be received by the collector and we > > were not sending it again, changed the test case file name to > > 026_stats as we can add more subscription-related stats in this test > > file itself > > Since we have pg_stat_subscription view, how about 026_worker_stats.pl? >
Sounds better. Updated patch attached. > The rests look good to me. > Okay, I'll push this patch tomorrow unless there are more comments. -- With Regards, Amit Kapila.
v28-0001-Add-a-view-to-show-the-stats-of-subscription-wor.patch
Description: Binary data
