Alvaro Herrera <alvhe...@alvh.no-ip.org> writes: > .. but see > https://postgr.es/m/cah2-wznwwu+9on9nzcnztk7ua238mctgpxyr1ty7u_msn5z...@mail.gmail.com > where this was already discussed. I think if we're going to workaround > PG_USED_FOR_ASSERTS_ONLY not actually working, we may as well get rid of > it entirely. My preference would be to fix it so that it works on more > platforms (at least Windows in addition to GCC).
Yeah, I do not think there is a reason to change the code if it's using PG_USED_FOR_ASSERTS_ONLY properly. We should either make that macro work on $compiler, or ignore such warnings from $compiler. regards, tom lane