On 2021-Nov-22, Daniel Gustafsson wrote: > > On 22 Nov 2021, at 12:10, Greg Nancarrow <gregn4...@gmail.com> wrote: > > > I've attached a patch to fix these warnings. > > LGTM.
.. but see https://postgr.es/m/cah2-wznwwu+9on9nzcnztk7ua238mctgpxyr1ty7u_msn5z...@mail.gmail.com where this was already discussed. I think if we're going to workaround PG_USED_FOR_ASSERTS_ONLY not actually working, we may as well get rid of it entirely. My preference would be to fix it so that it works on more platforms (at least Windows in addition to GCC). -- Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/ "In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth. That's because in Europe they call me by name, and in the US by value!"