Kuroda-san, On Thu, Nov 11, 2021 at 11:27 AM kuroda.hay...@fujitsu.com <kuroda.hay...@fujitsu.com> wrote: > I love your proposal because it will remove a bottleneck > for PostgreSQL build-in sharding. > > I read your patch briefly and I think basically it's good.
Great! Thanks for reviewing! > Currently I have only one comment. > > In your patch, postgres_fdw sends a COMMIT command to all entries in the hash > table > and waits for the result without a timeout from the first entry. > I think this specification is good because it's very simple, > but if a COMMIT for a particular foreign server could take some time, > I thought it might be more efficient to stop waiting for results and look at > the next entry. > This is how it works. First, we define a function similar to > pgfdw_get_result() > so that we can specify the timeout time as an argument to WaitLatchOrSocket(). > Then change the function called by do_sql_command_end () to the new one, > and change the callback function to skip if the result has not yet arrived > > How is it? Is it an unnecessary assumption that COMMIT takes time? Or is this > the next step? > I will put a PoC if needed. Hmm, I'm not sure the cost-effectiveness of this optimization is really high, because if the timeout expired, it means that something unusual would have happened, and that it would take a long time for the COMMIT command to complete (or abort at worst). So even if we processed the rest of the entries while waiting for the command result, we cannot reduce the total time very much. Maybe I'm missing something, though. Best regards, Etsuro Fujita
