On Wed, Nov 10, 2021 at 12:45 PM Bossart, Nathan <bossa...@amazon.com> wrote: > > On 11/8/21, 2:19 PM, "Joshua Brindle" <joshua.brin...@crunchydata.com> wrote: > > Thanks for the review, attached is an update with that comment fixed > > and also sgml documentation changes that I missed earlier. > > I think there are a number of documentation changes that are still > missing. I did a quick scan and saw the "is member of" language in > func.sgml, monitoring.sgml, pgbuffercache.sgml, pgfreespacemap.sgml, > pgrowlocks.sgml, pgstatstatements.sgml, and pgvisibility.sgml.
All of these and also adminpack.sgml updated. I think that is all of them but docs broken across lines and irregular wording makes it difficult. > <para> > By default, the <structname>pg_shmem_allocations</structname> view can be > - read only by superusers or members of the > <literal>pg_read_all_stats</literal> > - role. > + read only by superusers or roles with privilges of the > + <literal>pg_read_all_stats</literal> role. > </para> > </sect1> > > nitpick: "privileges" is misspelled. Fixed, thanks for reviewing.
0001-use-has_privs_for_roles-for-predefined-role-checks.patch
Description: Binary data
