On Wed, Oct 27, 2021 at 1:01 AM Mahendra Singh Thalor <mahi6...@gmail.com> wrote: > > > On Mon, 3 Aug 2020 at 15:02, Daniel Gustafsson <dan...@yesql.se> wrote: >> >> This thread has stalled and the patch no longer applies, so I'm marking this >> Returned with Feedback. Please feel free to open a new entry if this patch >> is >> revived. >> >> cheers ./daniel >> > > Hi all, > I took v3[1] patch from this thread and re-based on commit > head(5fedf7417b69295294b154a21). > > Please find the attached patch for review. >
I have done an initial review of the patch, I have a few comments, I will do a more detailed review later this week. 1. Commit message says that two options are 'consistency' and 'replay' whereas inside the patch those options are 'consistency' and 'catchup', Please change the commit message so that it matches with what the code is actually doing. 2. +static int +XLogReadFirstPage(XLogRecPtr targetPagePtr, char *readBuf) Add comments about what this function is doing. 3. Please run pg_indend on your code and fix all coding guideline violations 4. XLogReadFirstPage(). function is returning the size, but actually it either returns -1 or returns XLOG_BLCKSZ. So logically this function should just be returning boolean, true if it is able to read the first page, or false otherwise. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
