> On Thu, Nov 4, 2021 at 3:24 PM vignesh C <vignes...@gmail.com> wrote: > > > > On Thu, Nov 4, 2021 at 5:41 AM Peter Smith <smithpb2...@gmail.com> > wrote: > > > > > > FYI - I found a small problem with one of the new PublicationObjSpec > > > parser error messages that was introduced by the recent schema > > > publication commit [1]. > > > > > > The error message text is assuming that the error originates from > > > CREATE PUBLICATION, but actually that same error can also come from > > > ALTER PUBLICATION. > > > > > > For example, > > > > > > e.g.1) Here the error came from CREATE PUBLICATION, so the message > > > text looks OK. > > > > > > test_pub=# CREATE PUBLICATION p1 FOR t1; > > > 2021-11-04 10:50:17.208 AEDT [738] ERROR: FOR TABLE/FOR ALL TABLES > > > IN SCHEMA should be specified before the table/schema name(s) at > > > character 27 > > > 2021-11-04 10:50:17.208 AEDT [738] STATEMENT: CREATE PUBLICATION p1 > > > FOR t1; > > > ERROR: FOR TABLE/FOR ALL TABLES IN SCHEMA should be specified > > > before the table/schema name(s) LINE 1: CREATE PUBLICATION p1 FOR > > > t1; > > > ^ > > > ~~ > > > > > > e.g.2) Here the error came from ALTER PUBLICATION, so the message > > > text is not OK because the ALTER syntax [2] does not even have a FOR > > > keyword. > > > > > > test_pub=# ALTER PUBLICATION p1 SET t1; > > > 2021-11-04 10:51:53.912 AEDT [738] ERROR: FOR TABLE/FOR ALL TABLES > > > IN SCHEMA should be specified before the table/schema name(s) at > > > character 26 > > > 2021-11-04 10:51:53.912 AEDT [738] STATEMENT: ALTER PUBLICATION p1 > > > SET t1; > > > ERROR: FOR TABLE/FOR ALL TABLES IN SCHEMA should be specified > > > before the table/schema name(s) LINE 1: ALTER PUBLICATION p1 SET t1; > > > ^ > > > > Thanks for the comment, I changed the error message to remove the FOR > > keyword. The attached patch has the changes for the same. > > > > LGTM.
+1 Best regards, Hou zj
