On Tue, Oct 26, 2021 at 6:26 PM Greg Nancarrow <gregn4...@gmail.com> wrote: > > A few comments for some things I have noticed so far: > > 1) scantuple cleanup seems to be missing since the v33-0001 patch. > > 2) I don't think that the ResetExprContext() calls (before > FreeExecutorState()) are needed in the pgoutput_row_filter() and > pgoutput_row_filter_virtual() functions. > > 3) make check-world fails, due to recent changes to PostgresNode.pm.
These 3 comments all addressed in v37-0006 [1] ------ [1] https://www.postgresql.org/message-id/CAHut%2BPtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia.