On Thu, Sep 23, 2021 at 10:33 PM Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > > 5) publicationcmds.c > > I mentioned this in my last review [1] already, but I really dislike the > fact that OpenTableList accepts a list containing one of two entirely > separate node types (PublicationTable or Relation). It was modified to > use IsA() instead of a flag, but I still find it ugly, confusing and > possibly error-prone. > > Also, not sure mentioning the two different callers explicitly in the > OpenTableList comment is a great idea - it's likely to get stale if > someone adds another caller.
Fixed in v37-0001 [1] > 14) pgoutput_row_filter_update > > The function name seems a bit misleading, as it suggests might seem like > it updates the row_filter, or something. Should indicate it's about > deciding what to do with the update. Fixed in v37-0006 [1] ------ [1] https://www.postgresql.org/message-id/CAHut%2BPtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
