Peter Geoghegan <p...@bowt.ie> writes:
> On Mon, Mar 26, 2018 at 5:14 AM, Kyotaro HORIGUCHI
> <horiguchi.kyot...@lab.ntt.co.jp> wrote:
>> If no one objects, I'll mark this as Ready for Commit in a couple
>> of days.
> Thank you for the review, Horiguchi-san. It's hard to decide how
> important each goal is when coming up with a back-patchable fix like
> this. When the goals are somewhat in competition with each other, a
> second or a third opinion is particularly appreciated.
It looks good to me. The only real objection would be if someone came
up with a test case proving that there's a significant performance
degradation from the extra copies. But given that these are back
branches, it would take a pretty steep penalty for me to want to take
the risk of refactoring to avoid that.
I've pushed it with some cosmetic adjustments.
regards, tom lane
