On Thu, Sep 23, 2021 at 10:33 PM Tomas Vondra <tomas.von...@enterprisedb.com> wrote: > > 7) exprstate_list > > I'd just call the field / variable "exprstates", without indicating the > data type. I don't think we do that anywhere.
Fixed in v34. [1] > > > 8) RfCol > > Do we actually need this struct? Why not to track just name or attnum, > and lookup the other value in syscache when needed? > Fixed in v34. [1] > > 9) rowfilter_expr_checker > > * Walk the parse-tree to decide if the row-filter is valid or not. > > I don't see any clear explanation what does "valid" mean. > Updated comment in v34. [1] ------ [1] https://www.postgresql.org/message-id/CAHut%2BPvWk4w%2BNEAqB32YkQa75tSkXi50cq6suV9f3fASn5C9NA%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia.
