On Fri, Oct 22, 2021 at 12:19 AM vignesh C <vignes...@gmail.com> wrote: > > I could reproduce the issue by using the following test: > --- Setup > create schema sch1; > create schema sch2; > create table sch1.tbl1 (a int) partition by range (a); > create table sch2.tbl1_part1 partition of sch1.tbl1 for values from (1) to > (10); > create table sch2.tbl1_part2 partition of sch1.tbl1 for values from > (10) to (20); > create schema sch3; > create table sch3.t1(c1 int); > > --- Publication > create publication pub1 for all tables in schema sch3, table > sch1.tbl1, table sch2.tbl1_part1 with ( publish_via_partition_root > =on); > insert into sch1.tbl1 values(1); > insert into sch1.tbl1 values(11); > insert into sch3.t1 values(1); > > ---- Subscription > CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres host=localhost > port=5432' PUBLICATION pub1; > > The patch posted at [1] has the fix for the same. > [1] - > https://www.postgresql.org/message-id/CALDaNm1onqBEr0WE_e7%3DCNw3bURfrGRmbMjX31d-nx3FGLS10A%40mail.gmail.com >
Thanks for addressing this. I checked the updated code and did some more testing and the fix LGTM. I was also previously concerned about what the behavior should be when only including just the partitions of a partitioned table in a publication using ALL TABLES IN SCHEMA and having publish_via_partition_root=true. It seems to implicitly include the partitioned table in the publication. But I did some testing and found that this is the current behavior when only the partitions are individually included in a publication using TABLE, so it seems to be OK. Regards, Greg Nancarrow Fujitsu Australia
