On Sun, Mar 25, 2018 at 11:32 AM, Andrew Dunstan <andrew.duns...@2ndquadrant.com> wrote: > On Sun, Mar 25, 2018 at 3:55 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I noticed that doing pgindent with the current typedefs list available >> from the buildfarm caused a lot of havoc in what had been stable code. >> Looking into the reasons, it seems that: >> >> (1) "bool" is no longer listed as a typedef name (probably because >> stdbool.h makes it a macro instead); >> >> (2) "abs", "boolean", "iterator", "other", "pointer", "reference", >> "string", and "type" all now are listed as typedef names. >> >> It's probably okay to treat "boolean" as a typedef, but all those others >> are complete disasters. Anyone know where they're coming from? >> >> As for "bool", we could probably deal with that most reliably by >> having pgindent add it as a special case. Maybe we could get it >> back in there by having some trailing-edge buildfarm member >> contribute typedefs, but that seems like a solution with a rather >> limited half-life. >> > > > pgindent already has a list of blacklisted typedefs (see lines 121 to 123) >
Here's a patch to pgindent which I think will do what you want fairly simply, assuming you have identified all the offending tokens. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
pgindent-whiteblacklist.patch
Description: Binary data
