Hi Magnus! > 19 марта 2018 г., в 16:57, Magnus Hagander <mag...@hagander.net> написал(а): > > On Mon, Mar 19, 2018 at 12:24 PM, Magnus Hagander <mag...@hagander.net > <mailto:mag...@hagander.net>> wrote: > On Mon, Mar 19, 2018 at 11:40 AM, Andrey Borodin <x4...@yandex-team.ru > <mailto:x4...@yandex-team.ru>> wrote: > Hi, Daniel! > If we commit online checksums before SLRU checksums, we will need very neat > hacks if we decide to protect SLRU eventually. > > What do you think about this problem? > > One would be adjusted to work with the other, yes. It makes no sense to now > allow online enabling once SLRU protection is in there, and it doesn't make > sense for either of these patches to be blocking the other one for commit, > though it would of course be best to get both included. > > > Makes no sense to *not* allow it, of course. Meaning yes, that should be > handled. > > We don' t need to convert from "page format with no support for checksums" > (pre-11) to "page format with support for checksums" (11+) online. > > We do need to convert from "page format with support for checksums but no > checksums enabled" (11+) to "checksums enabled" online.
Oh, yes, you are right. Everything is fine, sorry for the noise. Best regards, Andrey Borodin.
