On Tue, 27 Feb 2018 13:35:33 +0100 Magnus Hagander <mag...@hagander.net> wrote:
> > Note that said commit (91f3ffc5249) is not limited to rearranging > > makefile. It also changes a lot into C code itself. So it is not a > > question of reverting commit - it is making new commit, which > > reverts changes in just one file. > > > Oh, I missed that. > > I think we should revert *just the changes to the Makefile*, and of > course leave the rest of the comimt. Can you confirm if that fixes > the problem? It seems that it is not so easy. I've tried to revert changes in the Makefile, and found out that some utilities (createlang, droplang, pg_isready) now need more common object files, than they need before this commit . Attached patch to makefile which fixe problem for 9.3 branch. I think it should do for 9.4 and 9.5 too. --
diff --git a/src/bin/scripts/Makefile b/src/bin/scripts/Makefile old mode 100644 new mode 100755 index 996db500e9..0dba267c20 --- a/src/bin/scripts/Makefile +++ b/src/bin/scripts/Makefile @@ -25,17 +25,17 @@ all: $(PROGRAMS) %: %.o $(WIN32RES) $(CC) $(CFLAGS) $^ $(libpq_pgport) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X) -SCRIPTS_COMMON = common.o dumputils.o kwlookup.o keywords.o -createdb: createdb.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -createlang: createlang.o $(SCRIPTS_COMMON) print.o mbprint.o | submake-libpq submake-libpgport -createuser: createuser.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -dropdb: dropdb.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -droplang: droplang.o $(SCRIPTS_COMMON) print.o mbprint.o | submake-libpq submake-libpgport -dropuser: dropuser.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -clusterdb: clusterdb.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -vacuumdb: vacuumdb.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -reindexdb: reindexdb.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport -pg_isready: pg_isready.o $(SCRIPTS_COMMON) | submake-libpq submake-libpgport +createdb: createdb.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +createlang: createlang.o common.o dumputils.o kwlookup.o keywords.o print.o mbprint.o | submake-libpq submake-libpgport +createuser: createuser.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +dropdb: dropdb.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +droplang: droplang.o common.o dumputils.o kwlookup.o keywords.o print.o mbprint.o | submake-libpq submake-libpgport +dropuser: dropuser.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +clusterdb: clusterdb.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +vacuumdb: vacuumdb.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +reindexdb: reindexdb.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport +pg_isready: pg_isready.o common.o dumputils.o kwlookup.o keywords.o | submake-libpq submake-libpgport + dumputils.c keywords.c: % : $(top_srcdir)/src/bin/pg_dump/% rm -f $@ && $(LN_S) $< . @@ -67,5 +67,5 @@ uninstall: clean distclean maintainer-clean: rm -f $(addsuffix $(X), $(PROGRAMS)) $(addsuffix .o, $(PROGRAMS)) - rm -f $(SCRIPTS_COMMON) print.o mbprint.o $(WIN32RES) + rm -f common.o dumputils.o kwlookup.o keywords.o print.o mbprint.o $(WIN32RES) rm -f dumputils.c print.c mbprint.c kwlookup.c keywords.c
