Hi, On 2018-02-20 20:57:36 +0100, Tomas Vondra wrote: > The question is how should the schema for TPC-H look like. Because if > you just do the usual test without any ALTER TABLE ADD COLUMN, then you > really won't get any difference at all. The fast default stuff will be > completely "inactive".
Well, there'll still be changed behaviour due to the changed sizes of structures and new out of line function calls. The deforming code is quite sensitive to such changes. I think just verifying that there's no meaningful effect with/without the patch is good enough. As soon as there's actual new columns that take advantage of the new functionality I think some degradation is fair game, you got some benefit for it. Greetings, Andres Freund